bito-code-review[bot] commented on code in PR #37411:
URL: https://github.com/apache/superset/pull/37411#discussion_r2771244152
##########
tests/unit_tests/sql/parse_tests.py:
##########
@@ -2942,6 +2942,39 @@ def test_check_functions_present(sql: str, engine: str,
expected: bool) -> None:
assert SQLScript(sql, engine).check_functions_present(functions) ==
expected
[email protected](
+ "sql, engine, expected",
Review Comment:
<!-- Bito Reply -->
Your reasoning is sound—both string and tuple formats are valid in pytest,
but maintaining consistency with the existing style in the file (as seen in the
test_check_functions_present and other parametrize decorators) is a good
practice. It avoids unnecessary changes and keeps the code uniform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
