rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2770115672


##########
superset-frontend/src/dashboard/components/Header/useHeaderActionsDropdownMenu.tsx:
##########
@@ -283,7 +288,12 @@ export const useHeaderActionsMenu = ({
     }
 
     // Set filter mapping
-    if (editMode && !isEmpty(dashboardInfo?.metadata?.filter_scopes)) {
+    if (
+      editMode &&
+      !isEmpty(
+        (dashboardInfo?.metadata as Record<string, unknown>)?.filter_scopes,

Review Comment:
   > Same — will be addressed by the `DashboardMetadata` interface follow-up.
   
   ✅ **Addressed in commit 7265f63d4a** - Added `filter_scopes` to 
`DashboardInfo.metadata` type, removed this cast as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to