rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2770060487
##########
superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.tsx:
##########
@@ -280,29 +343,29 @@ class ScatterPlotGlowOverlay extends PureComponent {
MIN_POINT_RADIUS +
normalizedValue * (MAX_POINT_RADIUS - MIN_POINT_RADIUS);
}
- pointLabel = `${roundDecimal(radiusProperty, 2)}`;
+ pointLabel = `${roundDecimal(radiusProperty as number, 2)}`;
Review Comment:
Addressed — thanks for the review!
##########
superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.tsx:
##########
@@ -280,29 +343,29 @@ class ScatterPlotGlowOverlay extends PureComponent {
MIN_POINT_RADIUS +
normalizedValue * (MAX_POINT_RADIUS - MIN_POINT_RADIUS);
}
- pointLabel = `${roundDecimal(radiusProperty, 2)}`;
+ pointLabel = `${roundDecimal(radiusProperty as number, 2)}`;
} else if (
Number.isFinite(minRadiusValue) &&
minRadiusValue === maxRadiusValue
) {
// All values are the same, use a fixed medium size
pointRadius = (MIN_POINT_RADIUS + MAX_POINT_RADIUS) / 2;
- pointLabel = `${roundDecimal(radiusProperty, 2)}`;
+ pointLabel = `${roundDecimal(radiusProperty as number, 2)}`;
Review Comment:
Addressed — thanks for the review!
##########
superset-frontend/plugins/legacy-plugin-chart-map-box/src/ScatterPlotGlowOverlay.tsx:
##########
@@ -280,29 +343,29 @@ class ScatterPlotGlowOverlay extends PureComponent {
MIN_POINT_RADIUS +
normalizedValue * (MAX_POINT_RADIUS - MIN_POINT_RADIUS);
}
- pointLabel = `${roundDecimal(radiusProperty, 2)}`;
+ pointLabel = `${roundDecimal(radiusProperty as number, 2)}`;
} else if (
Number.isFinite(minRadiusValue) &&
minRadiusValue === maxRadiusValue
) {
// All values are the same, use a fixed medium size
pointRadius = (MIN_POINT_RADIUS + MAX_POINT_RADIUS) / 2;
- pointLabel = `${roundDecimal(radiusProperty, 2)}`;
+ pointLabel = `${roundDecimal(radiusProperty as number, 2)}`;
} else {
// Use raw pixel values if they're already in a reasonable
range
pointRadius = Math.max(
MIN_POINT_RADIUS,
Math.min(pointRadius, MAX_POINT_RADIUS),
);
- pointLabel = `${roundDecimal(radiusProperty, 2)}`;
+ pointLabel = `${roundDecimal(radiusProperty as number, 2)}`;
Review Comment:
Addressed — thanks for the review!
##########
superset-frontend/plugins/legacy-preset-chart-nvd3/test/utils.test.ts:
##########
@@ -128,11 +128,13 @@ describe('nvd3/utils', () => {
});
it('returns a date formatter if format is smart_date', () => {
const time = new Date(Date.UTC(2018, 10, 21, 22, 11));
- expect(getTimeOrNumberFormatter('smart_date')(time)).toBe('10:11');
+ expect(
+ getTimeOrNumberFormatter('smart_date')(time as unknown as number),
Review Comment:
Addressed — thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
