kasiazjc commented on PR #37109: URL: https://github.com/apache/superset/pull/37109#issuecomment-3847985017
> cool thx 'duplicate' is in Datasets / Actions context menu: <img alt="image" width="1179" height="607" src="https://private-user-images.githubusercontent.com/222337631/544623637-cc6fb541-8ebe-40c3-971c-244f0a19f86c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAxNjA3NzQsIm5iZiI6MTc3MDE2MDQ3NCwicGF0aCI6Ii8yMjIzMzc2MzEvNTQ0NjIzNjM3LWNjNmZiNTQxLThlYmUtNDBjMy05NzFjLTI0NGYwYTE5Zjg2Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIwM1QyMzE0MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lY2UwZDcwYWQ4YTQ2NTIwMjJiMmYwYWJkMDcyYTEwYTM4OTk2YTIwYjI2NTJiNmY1ZmM3NWRmMTJhNmE3Y2E3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.QAnFA8H5WNcOokBYW0K1inkjg57GEiWA2CM-90UfJ74";> > > so different location/context, but same icon. oh, good point! I think ant design doesn't really a better option for duplicate or to differentiate the two. As both are in context and have tooltips I think it's ok to keep copy icon in both places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/222337631/544623637-cc6fb541-8ebe-40c3-971c-244f0a19f86c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAxNjA3NzQsIm5iZiI6MTc3MDE2MDQ3NCwicGF0aCI6Ii8yMjIzMzc2MzEvNTQ0NjIzNjM3LWNjNmZiNTQxLThlYmUtNDBjMy05NzFjLTI0NGYwYTE5Zjg2Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIwM1QyMzE0MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lY2UwZDcwYWQ4YTQ2NTIwMjJiMmYwYWJkMDcyYTEwYTM4OTk2YTIwYjI2NTJiNmY1ZmM3NWRmMTJhNmE3Y2E3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.QAnFA8H5WNcOokBYW0K1inkjg57GEiWA2CM-90UfJ74"](https://private-user-images.githubusercontent.com/222337631/544623637-cc6fb541-8ebe-40c3-971c-244f0a19f86c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NzAxNjA3NzQsIm5iZiI6MTc3MDE2MDQ3NCwicGF0aCI6Ii8yMjIzMzc2MzEvNTQ0NjIzNjM3LWNjNmZiNTQxLThlYmUtNDBjMy05NzFjLTI0NGYwYTE5Zjg2Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMjAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDIwM1QyMzE0MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lY2UwZDcwYWQ4YTQ2NTIwMjJiMmYwYWJkMDcyYTEwYTM4OTk2YTIwYjI2NTJiNmY1ZmM3NWRmMTJhNmE3Y2E3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.QAnFA8H5WNcOokBYW0K1inkjg57GEiWA2CM-90UfJ74"){kind=link}