semohr commented on code in PR #37396:
URL: https://github.com/apache/superset/pull/37396#discussion_r2758535625
##########
superset-frontend/src/explore/components/DataTableControl/index.tsx:
##########
@@ -305,13 +330,13 @@ export const useTableColumns = (
.map((key, index) => {
const colType = coltypes?.[index];
const firstValue = data[0][key];
- const headerLabel = columnDisplayNames?.[key] ?? key;
const originalFormattedTimeColumnIndex =
colType === GenericDataType.Temporal
? originalFormattedTimeColumns.indexOf(key)
: -1;
const isOriginalTimeColumn =
originalFormattedTimeColumns.includes(key);
+ const label = collabels?.[index];
Review Comment:
Indeed, fixed in latest commit, this was also an issue for colTypes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
