codeant-ai-for-open-source[bot] commented on PR #37009: URL: https://github.com/apache/superset/pull/37009#issuecomment-3728157185
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37009/files#diff-8a676fb002920d1d142fa9b19ded1ecb7b8b8d682cf9b9fe80f01b1a2314c86dR38-R38'><strong>Import risk</strong></a><br>The PR adds `AUTH_LDAP` to the top-level import from `flask_appbuilder.const`. If the installed Flask-AppBuilder version does not expose `AUTH_LDAP` at that location, importing it will raise ImportError at import time and cause the application to fail to start. Consider making the import robust or providing a fallback so older FAB versions remain compatible.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
