msyavuz commented on code in PR #37007:
URL: https://github.com/apache/superset/pull/37007#discussion_r2675489508
##########
superset-frontend/src/explore/components/controls/NumberControl/index.tsx:
##########
@@ -69,7 +80,8 @@ export default function NumberControl({
step={step}
placeholder={placeholder}
value={value}
- onChange={value => onChange?.(parseValue(value))}
+ onChange={handleChange}
+ onBlur={handleBlur}
Review Comment:
Hey @rusackas, i saw you looked into the original pr that introduced the
previous logic. Do you think the blur is a good compromise here in terms of ux?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
