eschutho commented on code in PR #35110:
URL: https://github.com/apache/superset/pull/35110#discussion_r2356912529
##########
.github/workflows/superset-playwright.yml:
##########
@@ -0,0 +1,141 @@
+name: Playwright E2E Tests
+
+on:
+ push:
+ branches:
+ - "master"
+ - "[0-9].[0-9]*"
+ pull_request:
+ types: [synchronize, opened, reopened, ready_for_review]
+ workflow_dispatch:
+ inputs:
+ ref:
+ description: 'The branch or tag to checkout'
+ required: false
+ default: ''
+ pr_id:
+ description: 'The pull request ID to checkout'
+ required: false
+ default: ''
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.run_id }}
+ cancel-in-progress: true
+
+jobs:
+ playwright-tests:
+ runs-on: ubuntu-22.04
+ # Allow workflow to succeed even if tests fail during shadow mode
+ continue-on-error: true
+ permissions:
+ contents: read
+ pull-requests: read
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ["chromium"]
+ app_root: ["", "/app/prefix"]
+ env:
+ SUPERSET_ENV: development
+ SUPERSET_CONFIG: tests.integration_tests.superset_test_config
+ SUPERSET__SQLALCHEMY_DATABASE_URI:
postgresql+psycopg2://superset:[email protected]:15432/superset
Review Comment:
can we use a config var here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
