betodealmeida opened a new pull request, #35021: URL: https://github.com/apache/superset/pull/35021
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> We currently allow for HTML to be used in the description of alerts/reports emails — this is a feature, not a bug, desired by users. The HTML might include malicious links, eg: ```html <a href="https://evil.com/";>Explore in Superset</a> ``` To prevent users from being tricked this PR introduces a redirection layer to any URLs in alerts/reports emails. The solution will: 1. Replace links in the email so that they point to a redirect page: https://evil.com/ -> https://superset/?url=https://evil.com 2. In the redirect page, if the link is external we ask for user confirmation (if it's not external we redirect automatically) 3. The user has to option to save the URL so that they're not prompted again in the future ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> <img width="1728" height="1080" alt="Screenshot 2025-09-04 at 2 05 48 PM" src="https://github.com/user-attachments/assets/cf4a34e6-b0b0-4ea2-af7d-a991f24b0c30"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
