LevisNgigi opened a new pull request, #35009:
URL: https://github.com/apache/superset/pull/35009

   <!---
   fix(sql): handle undefined template variables safely in query rendering
   -->
   
   ### SUMMARY
   This PR fixes a bug in SQL template processing when the 
`ENABLE_TEMPLATE_PROCESSING` feature flag is enabled.It handles undefined 
template variables gracefully by falling back to the original SQL.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   <img width="2560" height="1440" alt="template_processing" 
src="https://github.com/user-attachments/assets/941f36d8-12eb-4387-b0d4-b1408ddebb91";
 />
   
   ### TESTING INSTRUCTIONS
   Go to SQL Lab
   Use the following query:
   with ws1 as ( 
    select 1 as one
   )
   select * from ws1 --{{ ref('value_date_delinquent_dates')|length }}
   Run query
   It should run successfully with no errors
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ x] Has associated issue: Fixes #32044
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to