mistercrunch commented on PR #35033: URL: https://github.com/apache/superset/pull/35033#issuecomment-3260214464
Thanks for addressing this important visualization bug. Before merging, please consider: Package-lock.json: Please revert the unintentional changes to package-lock.json Fundamental approach: Rather than ensuring min/max are included after rounding, consider using Math.floor(minValue) and Math.ceil(maxValue) for the boundary breakpoints. This would: - Guarantee all data falls within ranges - Provide cleaner legend labels - Eliminate the complex adjustment logic Edge case testing: address the automated review concern about minimum value exclusion in a specific unit test. The precision calculation logic is sound, but the directional rounding approach might be more robust than the current fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
