catpineapple opened a new pull request, #35007: URL: https://github.com/apache/superset/pull/35007
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The test: tests/integration_tests/model_tests.py::TestSqlaTableModel::test_query_with_expr_groupby_timeseries uses MySQL as the database backend (SQLALCHEMY_EXAMPLES_URI). However, I noticed that the SQL sent to MySQL does not conform to expectations. It contains the PostgreSQL syntax "select state || gender || '_test'." This behavior is intended to implement string concatenation, but the '||' syntax is not applicable to MySQL. Although this case passes, its logic is flawed. The result of mysql 'select str1 || str2' ,concat multiple strings is 0. This 0 is used as the result of a subquery in the join SQL statement, resulting in a query result. However, this test only checks whether there is a result, not whether the result is correct, so it passes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
