msyavuz commented on code in PR #34850: URL: https://github.com/apache/superset/pull/34850#discussion_r2313164562
########## superset/commands/theme/import_themes.py: ########## @@ -29,7 +32,7 @@ logger = logging.getLogger(__name__) -def import_theme(config: dict[str, Any], overwrite: bool = False) -> None: +def import_theme(config: dict[str, Any], overwrite: bool = False) -> "Theme | None": Review Comment: We are doing this to defer type annotation i guess, i found [this](https://stackoverflow.com/a/51629186) SO thread on the topic but not sure where python is now currently. ########## tests/integration_tests/base_tests.py: ########## @@ -291,6 +291,200 @@ def get_or_create(self, cls, criteria, **kwargs): db.session.commit() return obj + # ============================================================================ + # Idempotent Test Helpers Review Comment: These look useful but are they used anywhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
