LevisNgigi commented on PR #34890: URL: https://github.com/apache/superset/pull/34890#issuecomment-3234638374
> > I am really curious as to how I can solve the pre-commit failing checks similar to the failing tests here. I have had troubles with it all day long. > > @LevisNgigi You just need to run: > > ``` > pre-commit run (works on staged but not committed changes) > ``` > > or > > ``` > pre-commit run --all-files (works on all files) > ``` > > Here's the output in this PR that shows the formatting problems: > > <img alt="Screenshot 2025-08-28 at 15 51 51" width="1417" height="911" src="https://private-user-images.githubusercontent.com/70410625/483303235-0b5b5ab9-6ee8-4fba-9637-9ac33f059161.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY0MDgzMDEsIm5iZiI6MTc1NjQwODAwMSwicGF0aCI6Ii83MDQxMDYyNS80ODMzMDMyMzUtMGI1YjVhYjktNmVlOC00ZmJhLTk2MzctOWFjMzNmMDU5MTYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODI4VDE5MDY0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyMThjZDc0ZGJjZTBhODBiNDAzNWMwZWEwYWViZGU0NmE3ODVjYjY3MTA5ODVkNDYyMzc2ZTZmNDczNGRiNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.X5XKqP1mmTMbhzoff9MhxK5RZIdwyS1ft6J-Appzbzk";> Thanks for the info, I ran this on my branch "pre-commit run --all-files" locally everything passes but in CI/CD it somehow fails. ─ pre-commit run --all-files ─╯ auto-walrus..............................................................Passed mypy (main)..............................................................Passed mypy (superset-extensions-cli)...........................................Passed check docstring is first.................................................Passed check for added large files..............................................Passed check yaml...............................................................Passed debug statements (python)................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed eslint (frontend).......................................................Skipped eslint (docs)............................................................Passed Type-Checking (Frontend)................................................Skipped Blacklist................................................................Passed Helm Docs................................................................Passed ruff-format..............................................................Passed ruff.....................................................................Passed pylint with custom Superset plugins......................................Passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://private-user-images.githubusercontent.com/70410625/483303235-0b5b5ab9-6ee8-4fba-9637-9ac33f059161.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY0MDgzMDEsIm5iZiI6MTc1NjQwODAwMSwicGF0aCI6Ii83MDQxMDYyNS80ODMzMDMyMzUtMGI1YjVhYjktNmVlOC00ZmJhLTk2MzctOWFjMzNmMDU5MTYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODI4VDE5MDY0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyMThjZDc0ZGJjZTBhODBiNDAzNWMwZWEwYWViZGU0NmE3ODVjYjY3MTA5ODVkNDYyMzc2ZTZmNDczNGRiNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.X5XKqP1mmTMbhzoff9MhxK5RZIdwyS1ft6J-Appzbzk"](https://private-user-images.githubusercontent.com/70410625/483303235-0b5b5ab9-6ee8-4fba-9637-9ac33f059161.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY0MDgzMDEsIm5iZiI6MTc1NjQwODAwMSwicGF0aCI6Ii83MDQxMDYyNS80ODMzMDMyMzUtMGI1YjVhYjktNmVlOC00ZmJhLTk2MzctOWFjMzNmMDU5MTYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA4MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwODI4VDE5MDY0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyMThjZDc0ZGJjZTBhODBiNDAzNWMwZWEwYWViZGU0NmE3ODVjYjY3MTA5ODVkNDYyMzc2ZTZmNDczNGRiNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.X5XKqP1mmTMbhzoff9MhxK5RZIdwyS1ft6J-Appzbzk"){kind=link}