Re: [PR] build(docker): update base debian image to 13 (trixie) [superset]

Fri, 22 Aug 2025 23:15:33 -0700 


korbit-ai[bot] commented on code in PR #34821:
URL: https://github.com/apache/superset/pull/34821#discussion_r2295248787


##########
docker/apt-install.sh:
##########
@@ -42,7 +42,7 @@ echo -e "${GREEN}Installing packages: $@${RESET}"
 apt-get install -yqq --no-install-recommends "$@"
 
 echo -e "${GREEN}Autoremoving unnecessary packages...${RESET}"
-apt-get autoremove -y
+apt-get autoremove -yqq --purge

Review Comment:
   ### Risky purge of package configurations <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The --purge flag in autoremove might remove configuration files that could 
be needed by other packages or for system recovery.
   
   
   ###### Why this matters
   Purging configuration files during automated cleanup in a Docker build 
context could lead to unintended side effects if any dependent packages rely on 
shared configurations.
   
   ###### Suggested change ∙ *Feature Preview*
   Remove the --purge flag from the autoremove command to preserve system 
configurations:
   ```bash
   apt-get autoremove -yqq
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/78b2d4d8-5bc2-4f6d-bb15-ec7ea755e601/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/78b2d4d8-5bc2-4f6d-bb15-ec7ea755e601?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/78b2d4d8-5bc2-4f6d-bb15-ec7ea755e601?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/78b2d4d8-5bc2-4f6d-bb15-ec7ea755e601?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/78b2d4d8-5bc2-4f6d-bb15-ec7ea755e601)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:3d10e6c6-605b-464e-b38a-67ae3389c7cd -->
   
   
   [](3d10e6c6-605b-464e-b38a-67ae3389c7cd)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to