dosubot[bot] commented on issue #34823: URL: https://github.com/apache/superset/issues/34823#issuecomment-3214822076
<!-- Answer --> The test failures happen because enabling the tagging system feature flag globally causes SQLAlchemy event listeners to be registered for the entire test run. These listeners introduce side effects that break tests not designed to handle them, like `update_tests.py` [source](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/tags/core.py). Integration tests use a fixture (`with_tagging_system_feature`) to enable the feature flag and register/clear event listeners for each test, ensuring isolation [source](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/tests/integration_tests/fixtures/tags.py). Unit tests like `update_tests.py` do not use this fixture, so listeners leak across test boundaries and cause unpredictable errors. To avoid failures, do not enable the tagging system feature flag globally for all tests. Instead, use a setup/teardown fixture to register and clear event listeners only for tests that need tagging. This pattern is already used in integration tests and can be adapted for unit tests. There is no built-in mechanism to automatically clean up listeners when the global flag changes, so explicit isolation is necessary. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/96d6e937-1912-4d02-9dad-425612fb55f4?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu b) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34823) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
