msyavuz commented on code in PR #34767: URL: https://github.com/apache/superset/pull/34767#discussion_r2292101374
########## superset-frontend/src/SqlLab/constants.ts: ########## @@ -66,13 +66,9 @@ export const TIME_OPTIONS = [ ]; // SqlEditor layout constants -export const SQL_EDITOR_GUTTER_HEIGHT = 5; -export const SQL_EDITOR_GUTTER_MARGIN = 3; -export const SQL_TOOLBAR_HEIGHT = 51; +export const SQL_EDITOR_GUTTER_HEIGHT = 4; Review Comment: I would go for using the existing tokens here, but not opposed to extending Superset specific tokens either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
