ceenayekta commented on PR #33189:
URL: https://github.com/apache/superset/pull/33189#issuecomment-3211108468
@rusackas @mistercrunch awesome news to hear :D
This PR was made on April 19, #34051 was made on July 3.
I'm wondering how that happen to put 2 person to work on an issue.
If you preferred to merge #34051, why did I received comments here?
Isn't there same procedures to take for accepting PRs? This PR got held back
for some enhancements like using `get_locales` instead of
`session.get("locale")`, and adding test functions and refactoring locale
constants...
The last thing @Quatters mentioned was to add test methods. However the
other PR has no test and based on the file naming convention on humanize
library, the argument of `activate` method takes bellow arguments. I'm not sure
if the #34051 will work with all superset locale strings, I hope @mistercrunch
you've already tested couple of locales before merged it!
[Activate
Function](https://github.com/jmoiron/humanize?tab=readme-ov-file#localization)
<img width="878" height="342" alt="image"
src="https://github.com/user-attachments/assets/e350ed08-fd42-4115-b035-2d9a1d1d0dbc";
/>
[Locale
Files](https://github.com/jmoiron/humanize/tree/master/src/humanize/locale)
<img width="1538" height="952" alt="image"
src="https://github.com/user-attachments/assets/db7d5b34-73dc-4222-8aab-3b989d32bb91";
/>
I'm not accepting to spend more time on this. Please prevent this mess for
the other PR #34629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
