Re: [PR] feat(bigquery): show materialized views [superset]

Tue, 19 Aug 2025 14:26:36 -0700 


korbit-ai[bot] commented on code in PR #34766:
URL: https://github.com/apache/superset/pull/34766#discussion_r2286371153


##########
superset-frontend/src/components/TableSelector/index.tsx:
##########
@@ -127,6 +127,8 @@ export const TableOption = ({ table }: { table: Table }) => 
{
     <TableLabel title={value}>
       {type === 'view' ? (
         <Icons.EyeOutlined iconSize="m" />
+      ) : type === 'materialized_view' ? (
+        <Icons.DatabaseOutlined iconSize="m" />

Review Comment:
   ### Misleading Icon for Materialized Views <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The database icon used for materialized views might cause confusion as it's 
traditionally used to represent databases, not materialized views.
   
   
   ###### Why this matters
   Users may incorrectly interpret materialized views as database connections 
rather than a specific type of view, leading to confusion in the UI.
   
   ###### Suggested change ∙ *Feature Preview*
   Consider using a more appropriate icon that better represents a materialized 
view, such as a combination of view and cache icons or a specific materialized 
view icon:
   ```typescript
   type === 'materialized_view' ? (
           <Icons.TableOutlined iconSize="m" />
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/df637020-c1a2-4491-b18e-007b14dfc017/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/df637020-c1a2-4491-b18e-007b14dfc017?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/df637020-c1a2-4491-b18e-007b14dfc017?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/df637020-c1a2-4491-b18e-007b14dfc017?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/df637020-c1a2-4491-b18e-007b14dfc017)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:a082ca13-aff6-4a1d-a6e7-8151a8ded4d3 -->
   
   
   [](a082ca13-aff6-4a1d-a6e7-8151a8ded4d3)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to