rusackas opened a new pull request, #34761:
URL: https://github.com/apache/superset/pull/34761

   ## Summary
   
   This PR fixes an issue where NULL values in categorical x-axis were not 
displayed in ECharts bar charts, while they were correctly shown in other chart 
types like pie charts.
   
   When a categorical column contains NULL values, these should be displayed as 
a valid category labeled as "<NULL>" in the bar chart, providing users 
visibility into missing data.
   
   Fixes #31481
   
   ## Testing
   
   ### Manual Testing
   1. Create a table with NULL values in a categorical column:
   ```sql
   CREATE TABLE browser_stats (browser VARCHAR(50), page VARCHAR(50));
   INSERT INTO browser_stats (browser, page) 
   VALUES 
    ('Firefox', 'home'),
    ('Chrome', 'home'),
    ('Chrome', 'home'),
    ('Safari', 'about'),
    (NULL, 'about');
   ```
   2. Create a bar chart using browser as the x-axis (categorical)
   3. Verify that NULL appears as a category labeled "<NULL>"
   
   ### Unit Tests
   - Added test case to verify NULL values are converted to `<NULL>` string for 
categorical axes
   - All existing tests pass
   
   ## Before/After
   - **Before**: NULL values were filtered out and not displayed
   - **After**: NULL values appear as "<NULL>" category in the chart
   
   ## Checklist
   - [x] Has associated issue: #31481
   - [x] Code follows project conventions
   - [x] Passes pre-commit checks
   - [x] Includes tests
   - [ ] Includes documentation (N/A - bug fix)
   
   🤖 Generated with [Claude Code](https://claude.ai/code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to