OmarIthawi commented on issue #25258:
URL: https://github.com/apache/superset/issues/25258#issuecomment-3199859017
Great work @ceenayekta! Thanks for your contribution.
Yes, some icons need to be reverted, esp. the ones with directional Arrows:
- ↩️
- ◀️
- ➡️
Anything with a global fixed direction should be flipped. Examples:
- Social media icons shouldn't be reversed
- Any logo :octocat:
- Glob icons 🌐
- Maps 🗺️
- Flags 🇿🇦
Some icons are okay whether flipped or not:
- 👮🏼♂️
- 🚗
- 👍🏼
And so on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
