korbit-ai[bot] commented on code in PR #34732:
URL: https://github.com/apache/superset/pull/34732#discussion_r2283048718
##########
superset-frontend/packages/superset-ui-core/src/components/Label/index.tsx:
##########
@@ -46,7 +46,7 @@ export function Label(props: LabelProps) {
const borderColorHover = onClick ? baseColor.borderHover : borderColor;
const labelStyles = css`
- transition: background-color ${transitionTiming}s;
+ transition: background-color ${theme.motionDurationMid}s;
Review Comment:
### Incorrect Duration Unit Application <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The transition duration unit is applied incorrectly. Ant Design's
motionDurationMid is already in seconds, but the code appends 's' to it.
###### Why this matters
This will result in an incorrect transition duration that's much longer than
intended (e.g., if motionDurationMid is 0.2, the actual duration will be 0.2s
seconds instead of the intended 0.2 seconds).
###### Suggested change ∙ *Feature Preview*
Remove the 's' from the transition duration as the Ant Design token already
includes the unit:
```typescript
transition: background-color ${theme.motionDurationMid};
```
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6bb325d5-0950-4552-9b40-845917d2283a/upvote)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6bb325d5-0950-4552-9b40-845917d2283a?what_not_true=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6bb325d5-0950-4552-9b40-845917d2283a?what_out_of_scope=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6bb325d5-0950-4552-9b40-845917d2283a?what_not_in_standard=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6bb325d5-0950-4552-9b40-845917d2283a)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:e2e314ee-0cc2-4afd-b5ef-3d8eb6e42f52 -->
[](e2e314ee-0cc2-4afd-b5ef-3d8eb6e42f52)
##########
superset-frontend/src/dashboard/components/FiltersBadge/DetailsPanel/index.tsx:
##########
@@ -175,7 +175,7 @@ const DetailsPanelPopover = ({
return (
<Popover
- color={`${theme.colors.grayscale.dark2}cc`}
+ color={`${theme.colorBgElevated}cc`}
Review Comment:
### Semantic Token Alpha Channel Manipulation <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The alpha channel ('cc') is manually appended to the Ant Design semantic
token, which may not work as expected since semantic tokens might already
include opacity settings.
###### Why this matters
Manual manipulation of semantic tokens can lead to unexpected visual results
and breaks the standardization that semantic tokens are meant to provide.
###### Suggested change ∙ *Feature Preview*
Use the proper Ant Design semantic token that already includes the desired
opacity level, or use a dedicated token for overlay backgrounds like
`colorBgMask`. If a specific opacity is required, consider using the proper Ant
Design token configuration:
```typescript
color={theme.colorBgMask}
```
Or if a specific opacity is absolutely necessary, consider defining a custom
semantic token in the theme configuration instead of manipulating the token
value directly.
###### Provide feedback to improve future suggestions
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b9635bbe-7731-4209-a84b-e21273517c98/upvote)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b9635bbe-7731-4209-a84b-e21273517c98?what_not_true=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b9635bbe-7731-4209-a84b-e21273517c98?what_out_of_scope=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b9635bbe-7731-4209-a84b-e21273517c98?what_not_in_standard=true)
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b9635bbe-7731-4209-a84b-e21273517c98)
</details>
<sub>
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:ba51ea51-1ca5-41a4-b604-774e281bd968 -->
[](ba51ea51-1ca5-41a4-b604-774e281bd968)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
