ap-Codkelden opened a new pull request, #34722: URL: https://github.com/apache/superset/pull/34722
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY First of all, the existing translation has several [translated placeholders](https://github.com/apache/superset/blob/fbcdf6909c4aa1a1a591f109f1728400532aac5c/superset/translations/uk/LC_MESSAGES/messages.po#L11277). These translated placeholders might cause `gettext` errors and, as a result, server errors: ``` File "/home/superset/dashboard/lib/python3.12/site-packages/flask_babel/__init__.py", line 588, in gettext return s if not variables else s % variables ~~^~~~~~~~~~~ KeyError: 'ресурси' ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Could not provide 5xx server errors due to NDA. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Just run: $ pybabel compile -d superset/superset/translations and read the output. There are 34 errors in the current file like these: ``` error: superset/superset/translations/uk/LC_MESSAGES/messages.po:1677: incompatible format for placeholder 1: 's' and 'd' are not compatible error: superset/superset/translations/uk/LC_MESSAGES/messages.po:3662: placeholders are incompatible error: superset/superset/translations/uk/LC_MESSAGES/messages.po:3773: unknown named placeholder 'name' error: superset/superset/translations/uk/LC_MESSAGES/messages.po:4140: unknown named placeholder 'число' ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
