Vitor-Avila commented on PR #34418: URL: https://github.com/apache/superset/pull/34418#issuecomment-3186785798
Hey @trentontrees I just manually tested this PR and confirmed the solution works. Could we add a test that covers this flow? Could be a unit test for `update_cross_filter_scoping` or an integration test to validate the import flow. I also left a minor comment in the code, but generally looks great! Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
