msyavuz commented on code in PR #34676:
URL: https://github.com/apache/superset/pull/34676#discussion_r2274093815
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -458,7 +458,14 @@ const RightMenu = ({
label: isFrontendRoute(child.url) ? (
<Link to={child.url || ''}>{menuItemDisplay}</Link>
) : (
- <Typography.Link href={child.url || ''}>
+ <Typography.Link
+ href={child.url || ''}
+ css={css`
+ display: flex !important;
+ align-items: center !important;
+ line-height: ${theme.sizeUnit * 10}px !important;
Review Comment:
Is there any other way to do this? Why do we need to set important here?
##########
superset-frontend/src/dashboard/components/gridComponents/new/DraggableNewComponent.tsx:
##########
@@ -36,18 +37,33 @@ interface DraggableNewComponentProps {
const NewComponent = styled.div`
${({ theme }) => css`
display: flex;
- flex-direction: row;
- flex-wrap: nowrap;
align-items: center;
- padding: ${theme.sizeUnit * 4}px;
- background: ${theme.colors.grayscale.light5};
+ justify-content: space-between;
+ padding: 0 ${theme.sizeUnit}px;
+ margin: ${theme.sizeUnit * 2}px ${theme.sizeUnit * 4}px;
+
+ // hack to make the drag preview image corners rounded
+ transform: translate(0, 0);
+ color: ${theme.colorText};
+ background-color: ${theme.colorBgLayout};
+ border-radius: 4px;
Review Comment:
There should be a token for this as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
