justinpark commented on code in PR #34606:
URL: https://github.com/apache/superset/pull/34606#discussion_r2271565683
##########
superset-frontend/packages/superset-ui-core/src/query/types/QueryFormData.ts:
##########
@@ -204,6 +204,15 @@ export interface SqlaFormData extends BaseFormData {
export type QueryFormData = SqlaFormData;
+export type LatestQueryFormData =
Review Comment:
latestQueryFormData was initially assigned an empty object, and there are
many specs with a value of {}. I resolved this issue by changing it to
Partial<QueryFormData>.
```
// superset-frontend/src/components/Chart/chartAction.js
if (
!chart.latestQueryFormData ||
Object.keys(chart.latestQueryFormData).length === 0
) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
