kgabryje opened a new pull request, #34660:
URL: https://github.com/apache/superset/pull/34660

   
   ### SUMMARY
   Due to a change from https://github.com/apache/superset/pull/33769, changing 
page in a table chart with server side pagination enabled had no effect on a 
dashboard. The change in `getRelevantDataMask` function that broke the feature 
doesn't appear to be necessary for the deckgl feature as it's only used for 
extracting ownState from datamask, so it should be safe to revert it to the 
previous state.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   1. Create a table chart with server side pagination
   2. Add it to a dashboard
   3. Verify that changing pages works
   4. Create a Multiple Layer deckgl chart
   5. Add it to a dashboard
   6. Add a native filter for the decgkl chart and set scoping to some of the 
layers
   7. Verify that filtering works as expected
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to