michael-s-molina commented on PR #34526: URL: https://github.com/apache/superset/pull/34526#issuecomment-3179045979
> Being behind a feature flag and with a beta feels like it's ok to make things a bit more of a construction site, showing things not fully all done and a bit of scaffolding. Frankly on TopN it's probably easier to push forward and build the feature than removing/re-adding the controls. @mistercrunch, I’ve been reflecting on our current PRs and the discussion we had at the last Town Hall about keeping master always releasable. While this isn’t directly about this PR, it prompted me to share my thoughts. If our goal is to be able to release from master at any time, we need to rethink how we structure our PRs. Only complete or releasable features should be merged into master. Currently, we have several PRs that require follow-up—not for adding new features, but just to finish existing ones. Effectively, we’re treating master as a development branch, where features are completed across multiple PRs. While I appreciate the benefits of smaller PRs and collaborating as a team on features, I think this should take place in dedicated feature branches. These branches can be merged into master only when the work is finished or in a releasable state. This approach would greatly improve the stability of master, while also giving us a safe space (feature branches) to collaborate and iterate before merging. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
