VasilijeBursac commented on code in PR #34640:
URL: https://github.com/apache/superset/pull/34640#discussion_r2267682967
##########
superset-frontend/src/pages/Login/index.tsx:
##########
@@ -74,7 +74,62 @@ const StyledLabel = styled(Typography.Text)`
`}
`;
+const StyledBackground = styled.div`
+ ${({ theme }) => {
+ const bgImageUrl = theme.loginPageBackgroundImageUrl;
+ const overlayColor =
+ theme.loginPageBackgroundOverlayColor || 'rgba(0, 0, 0, 0.5)';
Review Comment:
> How does this default work with dark mode now?
The default overlay color (`rgba(0, 0, 0, 0.5)`) currently applies to both
light and dark themes. You can see this in the first two "after" screenshots.
Both use the default and show the semi-transparent black overlay regardless of
theme mode.
I did consider setting different defaults based on the theme algorithm (e.g.
lighter overlay for default, darker for dark), but decided it might be overkill
since the overlay color and transparency are fully customizable via the
`loginPageBackgroundOverlayColor` token. That gives users precise control over
branding and contrast if they want to override the default.
Do you have any suggestions or preferences for how we should handle defaults
across themes (different approach, different default value, etc.)? I’m happy to
adjust if there’s a clearer UX or branding benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
