greggailly commented on code in PR #34111:
URL: https://github.com/apache/superset/pull/34111#discussion_r2265819180
##########
superset/sql_lab.py:
##########
@@ -475,7 +475,9 @@ def execute_sql_statements( # noqa: C901
db.session.commit()
# Hook to allow environment-specific mutation (usually comments)
to the SQL
- query.executed_sql = database.mutate_sql_based_on_config(block)
+ query.executed_sql = database.mutate_sql_based_on_config(
+ block, is_split=config["MUTATE_AFTER_SPLIT"]
Review Comment:
We are currently looking into this as our setup requires to use this hook
for permissions related issues. Our database connection is setup with a user
which by default has no permissions and settings role dynamically at each
request. We are trying to achieve this for both charts and sqllab so making it
my consistent would definitely be great !
@mistercrunch redesigning the hook does seem like a good idea for long term.
In the meantime is merging this PR considered ou maybe splitting the hook
into a specific `SQLLAB_QUERY_MUTATOR`(but means both codepaths continue to
diverge for now...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
