mistercrunch commented on code in PR #34560:
URL: https://github.com/apache/superset/pull/34560#discussion_r2265615375
##########
docs/docs/configuration/theming.mdx:
##########
@@ -62,12 +62,13 @@ THEME_DARK = {
}
}
-# Theme behavior settings
-THEME_SETTINGS = {
- "enforced": False, # If True, forces default theme always
- "allowSwitching": True, # Allow users to switch between themes
- "allowOSPreference": True, # Auto-detect system theme preference
-}
+# Enable UI-based theme administration for admins
+ENABLE_UI_THEME_ADMINISTRATION = True
+
+# To force a single theme on all users, set THEME_DARK = None
+# When both THEME_DEFAULT and THEME_DARK are defined:
+# - Users can manually switch between themes
+# - OS preference detection is automatically enabled
Review Comment:
Thinking about the embedder's perspective, I believe they can set whatever
theme they'd like programmatically, the question is whether that's sufficient
or whether we want for them to be able to reference arbitrary themes from the
CRUD, including the system ones and the auto-switch. For now, I'm thinking the
simplest is clearly to have them manage which theme they want to set
programmatically, and in isolation from the CRUD: basically if you want to
control the theme you pass in a theme object as you embed.
I guess the embedded sdk could also have a layer to retrieve theme
definitions from the Theme CRUD using the API too, like fetch whatever theme
and use it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
