Copilot commented on code in PR #34330:
URL: https://github.com/apache/superset/pull/34330#discussion_r2263558995
##########
superset-frontend/packages/superset-ui-chart-controls/src/utils/getColorFormatters.ts:
##########
@@ -218,3 +268,7 @@ export const getColorFormatters = memoizeOne(
[],
) ?? [],
);
+
+function isString(value: string) {
+ return typeof value === 'string';
+}
Review Comment:
The isString function is redundant because the parameter is already typed as
string. This will always return true. Either change the parameter type to
'unknown' or remove this function and use direct type checks where needed.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
