Re: [PR] fix: strip html content when applying filter from drill-down menu [superset]

Thu, 07 Aug 2025 14:59:29 -0700 


korbit-ai[bot] commented on code in PR #34605:
URL: https://github.com/apache/superset/pull/34605#discussion_r2261530636


##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailMenuItems.tsx:
##########
@@ -227,7 +238,7 @@ const DrillDetailMenuItems = ({
         {filters.length > 1 && (
           <Menu.Item
             key="drill-detail-filter-all"
-            onClick={openModal.bind(null, filters)}
+            onClick={openModal.bind(null, cleanedFilters)}

Review Comment:
   ### Missing Event Parameter in Modal Open Handler <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The openModal callback expects filters and event parameters, but the event 
parameter is not being passed when binding with cleanedFilters.
   
   
   ###### Why this matters
   Missing the event parameter could lead to undefined event object in the 
openModal function, potentially causing issues when the onClick handler tries 
to use the event object.
   
   ###### Suggested change ∙ *Feature Preview*
   Modify the code to properly pass both the filters and event parameters:
   ```typescript
   onClick={(event) => openModal(cleanedFilters, event)}
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/61620fcd-8ace-4753-8b1f-22b56e608ea0)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:195ba756-98cd-4135-afaf-c6771552cbe9 -->
   
   
   [](195ba756-98cd-4135-afaf-c6771552cbe9)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to