justinpark commented on code in PR #34526:
URL: https://github.com/apache/superset/pull/34526#discussion_r2261076062
##########
superset-frontend/packages/superset-ui-core/src/chart/components/SuperChart.tsx:
##########
@@ -186,6 +188,44 @@ class SuperChart extends PureComponent<Props, {}> {
theme,
});
+ // Check if Matrixify is enabled - use rawFormData (snake_case)
+ const matrixifyEnabled = isMatrixifyEnabled(chartProps.rawFormData);
+
+ if (matrixifyEnabled) {
+ const matrixifyChart = (
+ <MatrixifyGridRenderer
+ formData={chartProps.rawFormData}
+ datasource={chartProps.datasource}
+ width={width}
+ height={height}
+ hooks={chartProps.hooks}
+ />
+ );
+
+ // Apply wrapper if provided
+ const wrappedChart = Wrapper ? (
+ <Wrapper width={width} height={height}>
+ {matrixifyChart}
+ </Wrapper>
+ ) : (
+ matrixifyChart
+ );
+
+ // Include error boundary unless disabled
+ return disableErrorBoundary === true ? (
Review Comment:
It appears you miss a condition to render with a error boundary
```suggestion
return disableErrorBoundary === <missing condition> ? (
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
