rafal-celinski opened a new pull request, #34592: URL: https://github.com/apache/superset/pull/34592
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The previous approach, which relied on a single query with aggregate functions (e.g., SUM, COUNT), has been replaced. The new implementation achieves the same result by executing multiple, separate queries with varying GROUP BY clauses. These results are then merged to construct the final table with all required summary rows in their correct positions. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before: <img width="378" height="315" alt="image" src="https://github.com/user-attachments/assets/725a1be6-a5fd-4e48-90c1-224d938363c7"; /> After: <img width="378" height="320" alt="image" src="https://github.com/user-attachments/assets/ec97f841-5ef4-4d7b-bc04-9b69007f8dcc"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Create a Pivot Table chart. 2. Add one or more dimensions to the Rows (e.g., Country). 3. Use a non-additive metric, such as AVG(sales). 4. Enable "Show Column Totals" in the customization options. 5. Observe the grand total value. It should now be calculated correctly as the average of the entire underlying dataset (e.g., the true AVG(sales) across all countries), not as an incorrect sum of averages of the displayed per-country averages. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #25747 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
