sfirke opened a new pull request, #34583:
URL: https://github.com/apache/superset/pull/34583

   ### SUMMARY
   This is a new attempt at fixing #24072 . It takes a different approach than 
my first attempt, https://github.com/apache/superset/pull/27442. This time it 
makes the ordering change in the Microsoft SQL Server (mssql) spec rather than 
for all engines.
   
   I checked that this solves the problem in my environment. I would like input 
on whether my change to `compile_sqla_query` is correct.
   
   ### TESTING INSTRUCTIONS
   Deploy to an environment with SQL Server data warehouse, try drilling and 
flipping through the pages. It works for me, if needed I can produce a video.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #24072
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to