rusackas commented on code in PR #34306:
URL: https://github.com/apache/superset/pull/34306#discussion_r2255049692
##########
superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.test.tsx:
##########
@@ -89,8 +80,8 @@ test('Should lock the vertical scroll when the popover is
visible', () => {
);
});
-test('Should place popover at the top', async () => {
- const { setStateMock } = setupTest({
+test.skip('Should place popover at the top', async () => {
Review Comment:
Maybe these skipped tests are a concern... or not... perhapse I'll pull in
this file from `master` and see if CI still passes, if we're concerned here.
##########
superset-frontend/src/explore/components/controls/ControlPopover/ControlPopover.test.tsx:
##########
@@ -89,8 +80,8 @@ test('Should lock the vertical scroll when the popover is
visible', () => {
);
});
-test('Should place popover at the top', async () => {
- const { setStateMock } = setupTest({
+test.skip('Should place popover at the top', async () => {
Review Comment:
Maybe these skipped tests are a concern... or not... perhaps I'll pull in
this file from `master` and see if CI still passes, if we're concerned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
