sadpandajoe commented on PR #34490: URL: https://github.com/apache/superset/pull/34490#issuecomment-3146051668
From Claude on this major bump: > Based on my analysis, this would be a breaking change and cannot be upgraded out of the box safely. > > Direct Answer: NOT SAFE for out-of-the-box upgrade > > Reason: ECharts 6.0.0 introduces visual breaking changes that will immediately affect Superset: > > 1. Default legend position changes from top to bottom - this will break dashboard layouts > 2. New default color palette - charts will have different colors than expected > 3. Theme changes - visual appearance will change across all ECharts-based charts > 4. Grid positioning changes - axis positioning may shift > > Impact on Superset > > Since Superset uses ECharts extensively (20+ chart types including Bar, Line, Pie, Timeseries, etc.), users would immediately notice: > - Different chart colors > - Legends appearing in wrong positions > - Potential layout breaks in existing dashboards > - Visual inconsistency with current Superset design > > Required for Safe Upgrade > > The upgrade requires migration work to: > 1. Override new defaults to preserve current visual behavior > 2. Add compatibility flags (richInheritPlainLabel: false, etc.) > 3. Explicitly set theme/color configurations > 4. Test all chart types for visual regressions > > Bottom line: This is a major version bump with breaking visual changes. It needs careful migration planning rather than a simple dependency update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
