Vitor-Avila commented on code in PR #34319:
URL: https://github.com/apache/superset/pull/34319#discussion_r2248531221
##########
superset/security/manager.py:
##########
@@ -570,6 +571,32 @@ def can_access_datasource(self, datasource:
"BaseDatasource") -> bool:
return True
+ def can_drill_dataset_via_dashboard_access(
+ self, dataset: "BaseDatasource", dashboard: "Dashboard"
+ ) -> bool:
+ """
+ Return True if an embedded user or DASHBOARD_RBAC user can drill a
dataset.
Review Comment:
@eschutho initially I had a FF to gate this, but was advised against here :
https://github.com/apache/superset/pull/34319#issuecomment-3119476516
This will still be controlled by regular role perm. If the embedded role has
`can_drill_info` on `Dataset` they'll have access to this endpoint, otherwise
they won't have it. Then the UI also checks for the regular permissions to show
(or not) the **Drill by** and **Drill to Detail** options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
