sadpandajoe opened a new pull request, #34442: URL: https://github.com/apache/superset/pull/34442
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Add comprehensive unit tests for `EncryptedField` component (0% → ~80% coverage). ## Changes - **27 unit tests** covering component logic, state management, user interactions, error handling, and accessibility - Engine-agnostic test design supports future database engines (BigQuery, Google Sheets, etc.) - Proper async FileReader mocking and error simulation - Form integration and validation error handling tests ## Test Categories - **Core Logic** (6 tests): Field name resolution, parameter processing - **State Management** (5 tests): Upload options, change handlers, form integration - **Component Behavior** (8 tests): Rendering logic, accessibility, form validation - **Error Handling** (6 tests): Malformed data, file errors, edge cases - **Validation** (2 tests): Error props, graceful degradation ## Key Features - Generic test patterns work with any engine/field combination - Follows established patterns from `OAuth2ClientField.test.tsx` - Includes TODO comments for future UI validation error display - Error message consistency with component implementation 🤖 Generated with [Claude Code](https://claude.ai/code) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
