korbit-ai[bot] commented on code in PR #34178: URL: https://github.com/apache/superset/pull/34178#discussion_r2242653134
########## superset-frontend/src/components/Chart/DrillDetail/useDrillDetailMenuItems.tsx: ########## @@ -0,0 +1,269 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { + Dispatch, + ReactNode, + SetStateAction, + useCallback, + useMemo, +} from 'react'; +import { isEmpty } from 'lodash'; +import { + Behavior, + BinaryQueryObjectFilterClause, + css, + extractQueryFields, + getChartMetadataRegistry, + QueryFormData, + removeHTMLTags, + styled, + t, +} from '@superset-ui/core'; +import { useSelector } from 'react-redux'; +import { MenuItem } from '@superset-ui/core/components/Menu'; +import { RootState } from 'src/dashboard/types'; +import { getSubmenuYOffset } from '../utils'; +import { MenuItemTooltip } from '../DisabledMenuItemTooltip'; +import { useMenuItemWithTruncation } from '../MenuItemWithTruncation'; + +const DRILL_TO_DETAIL = t('Drill to detail'); +const DRILL_TO_DETAIL_BY = t('Drill to detail by'); +const DISABLED_REASONS = { + DATABASE: t( + 'Drill to detail is disabled for this database. Change the database settings to enable it.', + ), + NO_AGGREGATIONS: t( + 'Drill to detail is disabled because this chart does not group data by dimension value.', + ), + NO_FILTERS: t( + 'Right-click on a dimension value to drill to detail by that value.', + ), + NOT_SUPPORTED: t( + 'Drill to detail by value is not yet supported for this chart type.', + ), +}; + +function getDisabledMenuItem( + children: ReactNode, + menuKey: string, + ...rest: unknown[] +): MenuItem { + return { + disabled: true, + key: menuKey, + label: ( + <div + css={css` + white-space: normal; + max-width: 160px; + `} + > + {children} + </div> + ), + ...rest, + }; +} + +const Filter = ({ + children, + stripHTML = false, +}: { + children: ReactNode; + stripHTML: boolean; +}) => { + const content = + stripHTML && typeof children === 'string' + ? removeHTMLTags(children) + : children; + return <span>{content}</span>; +}; Review Comment: ### Inconsistent HTML sanitization <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The Filter component conditionally sanitizes HTML content based on a boolean flag, which could lead to XSS vulnerabilities when stripHTML is false. ###### Why this matters If untrusted content is passed to this component with stripHTML=false, malicious HTML/JavaScript could be executed in the browser context. ###### Suggested change ∙ *Feature Preview* ```typescript const Filter = ({ children, stripHTML = true, // Default to true for safety }: { children: ReactNode; stripHTML: boolean; }) => { const content = typeof children === 'string' ? stripHTML ? removeHTMLTags(children) : children : children; return <span>{content}</span>; }; ``` ###### Provide feedback to improve future suggestions [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5fb5d24e-ed2f-43b7-84c9-cb7f396d19e4/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5fb5d24e-ed2f-43b7-84c9-cb7f396d19e4?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5fb5d24e-ed2f-43b7-84c9-cb7f396d19e4?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5fb5d24e-ed2f-43b7-84c9-cb7f396d19e4?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/5fb5d24e-ed2f-43b7-84c9-cb7f396d19e4) </details> <sub> 💬 Looking for more details? Reply to this comment to chat with Korbit. </sub> <!--- korbi internal id:a6d907d6-4d39-4977-8b50-7406024fca51 --> [](a6d907d6-4d39-4977-8b50-7406024fca51) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
