mistercrunch commented on code in PR #34296:
URL: https://github.com/apache/superset/pull/34296#discussion_r2232218830
##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/customControls.tsx:
##########
@@ -41,6 +41,53 @@ import {
import { checkColumnType } from '../utils/checkColumnType';
import { isSortable } from '../utils/isSortable';
+// Aggregation choices with computation methods for plugins and controls
+export const aggregationChoices = {
+ raw: {
+ label: 'Force server-side aggregation',
Review Comment:
yeah though call on naming this properly... clearly we can expand on the
tooltip and put much more information and can be a bit more technical there
too. The feature is funky for a variety of reasons, one is that you have to
pick 2 aggregations (one one the time grain, and one across time - sometimes
across the raw data, sometimes on the time series itself), and many
combinations might not make sense. LAST_VALUE is the most intuitive to me (and
the default).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
