mistercrunch opened a new pull request, #34308:
URL: https://github.com/apache/superset/pull/34308
Been meaning to implement this for years.
## Summary
Adds **"Group remaining as Others"** checkbox to series limit control.
When enabled, remaining series beyond the limit are grouped into "Others"
instead of being randomly truncated at row limits.
Includes DRY refactoring that eliminates ~90% code duplication between
JOIN and 2-phase query paths.
## Changes
- **Frontend**: New checkbox control next to series limit
- **Backend**: `group_others_when_limit_reached` parameter with ANSI SQL
CASE expressions
- **Refactor**: Extract `_apply_series_others_grouping()` method with
condition factory pattern
- **Tests**: Unit tests for refactored logic
## Technical Details
**Before**: 63 lines of duplicated CASE expression logic
**After**: 17 lines using shared method + condition factories
**Backwards compatible**: Default `false`, generates identical SQL when
disabled
## Files Changed
- `superset/common/query_object.py` - Add parameter
- `superset/models/helpers.py` - Add method + refactor both query paths
- `superset/charts/schemas.py` - Add API field
- `superset-frontend/.../sharedControls.tsx` - Add control
- `superset-frontend/.../sections.tsx` - Update layout
- `tests/unit_tests/models/helpers_test.py` - Add tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
