Copilot commented on code in PR #34305:
URL: https://github.com/apache/superset/pull/34305#discussion_r2229173297
##########
superset-frontend/package.json:
##########
@@ -72,7 +72,7 @@
"test": "cross-env NODE_ENV=test
NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80% --silent",
"test-loud": "cross-env NODE_ENV=test
NODE_OPTIONS=\"--max-old-space-size=8192\" jest --max-workers=80%",
"type": "tsc --noEmit",
- "update-maps": "jupyter nbconvert --to notebook --execute --inplace
'plugins/legacy-plugin-chart-country-map/scripts/Country Map GeoJSON
Generator.ipynb' -Xfrozen_modules=off",
+ "update-maps": "cd plugins/legacy-plugin-chart-country-map/scripts &&
jupyter nbconvert --to notebook --execute --inplace --allow-errors
--ExecutePreprocessor.timeout=1200 'Country Map GeoJSON Generator.ipynb'",
Review Comment:
[nitpick] The hardcoded timeout value of 1200 seconds (20 minutes) should be
documented or made configurable. Consider adding a comment explaining why this
specific timeout was chosen.
```suggestion
"update-maps": "cd plugins/legacy-plugin-chart-country-map/scripts &&
jupyter nbconvert --to notebook --execute --inplace --allow-errors
--ExecutePreprocessor.timeout=${EXECUTE_PREPROCESSOR_TIMEOUT:-1200} 'Country
Map GeoJSON Generator.ipynb'",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
