Re: [PR] fix: build issues on master with 'npm run dev' [superset]

Tue, 22 Jul 2025 14:59:31 -0700 


korbit-ai[bot] commented on code in PR #34272:
URL: https://github.com/apache/superset/pull/34272#discussion_r2223908738


##########
superset-frontend/webpack.config.js:
##########
@@ -319,6 +319,13 @@ const config = {
           './node_modules/@storybook/react-dom-shim/dist/react-16',
         ),
       ),
+      // Workaround for react-color trying to import non-existent icon
+      '@icons/material/UnfoldMoreHorizontalIcon': path.resolve(
+        path.join(
+          APP_DIR,
+          './node_modules/@icons/material/CubeUnfoldedIcon.js',
+        ),
+      ),

Review Comment:
   ### Icon Substitution Mismatch <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The webpack alias substitutes UnfoldMoreHorizontalIcon with 
CubeUnfoldedIcon, which are visually different icons that could impact the user 
interface.
   
   
   ###### Why this matters
   Using a different icon than what was intended by react-color could confuse 
users and break the expected visual functionality of the color picker component.
   
   ###### Suggested change ∙ *Feature Preview*
   Instead of substituting with a different icon, consider:
   1. Either installing the correct @icons/material package that contains 
UnfoldMoreHorizontalIcon
   2. Or create a minimal implementation of UnfoldMoreHorizontalIcon that 
matches the expected visual:
   ```javascript
   // Create a new file: @icons/material/UnfoldMoreHorizontalIcon.js
   export default function UnfoldMoreHorizontalIcon(props) {
     return (
       <svg viewBox="0 0 24 24" {...props}>
         <path d="M12 18l4-4h-8l4 4zm0-12l-4 4h8l-4-4z" />
       </svg>
     );
   }
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e8fb6da7-5340-42a1-a775-09d20d1babdf)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:002a17ba-b5b9-4e92-bf92-f20197c34db4 -->
   
   
   [](002a17ba-b5b9-4e92-bf92-f20197c34db4)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to