msyavuz commented on code in PR #34213:
URL: https://github.com/apache/superset/pull/34213#discussion_r2222460050
##########
superset/utils/core.py:
##########
@@ -120,6 +129,32 @@
ADHOC_FILTERS_REGEX = re.compile("^adhoc_filters")
+TYPE_MAPPING = {
+ re.compile(r"INT", re.IGNORECASE): "integer",
+ re.compile(r"CHAR|TEXT|VARCHAR", re.IGNORECASE): "string",
+ re.compile(r"DECIMAL|NUMERIC|FLOAT|DOUBLE", re.IGNORECASE): "floating",
+ re.compile(r"BOOL", re.IGNORECASE): "boolean",
+ re.compile(r"DATE|TIME", re.IGNORECASE): "datetime64",
+}
+
+Metric_Map_Type = {
Review Comment:
This is a constant, so the naming should be capital snake case same as the
other ones
```suggestion
METRIC_MAP_TYPE = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
