EnxDev opened a new pull request, #34237: URL: https://github.com/apache/superset/pull/34237
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes various regressions introduced by the `theming project` and introduces a new reusable component, `ModalTitleWithIcon`, to standardize the rendering of modal titles across the application. ✅ What's Included - Fixed styling inconsistencies and regressions caused by recent theming changes. - Added ModalTitleWithIcon to unify and simplify modal title implementations. - Supports both static and edit/add dynamic titles via editModeConfig. - Allows passing custom icons, ensuring consistent layout and spacing. - Replaced duplicated JSX title blocks with this new component across multiple modals. 🎯 Why - To clean up duplicated code and ensure consistent UX across modals. - To provide a single source of truth for icon size, spacing, and typography in modal headers. To make future changes to modal titles easier and less error-prone. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> - Before - After - Before - After - Before - After - Before - After - Before - After <img width="794" height="535" alt="after-1" src="https://github.com/user-attachments/assets/fd41aa29-36e4-4f20-a278-c068c7677ee9"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - All tests should pass ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
