gabotorresruiz opened a new pull request, #34218: URL: https://github.com/apache/superset/pull/34218
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR removes duplicated logic from `ThemeController` and ensures it relies solely on the single `themeObject` instance managed by the `Theme` class. This guarantees consistent theme updates across all components when the theme changes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> Before: <img width="2202" height="731" alt="image" src="https://github.com/user-attachments/assets/8836df3e-a3d9-4a9e-8e88-f7beed453859"; /> After: <img width="1774" height="436" alt="image" src="https://github.com/user-attachments/assets/ba9f8841-be49-4487-89b6-41fa74e0dfcf"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Load a page with charts in light and dark mode - Chart styles should be changing when the theme changes (text colors, backgrounds, etc) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
