aminghadersohi commented on code in PR #33976: URL: https://github.com/apache/superset/pull/33976#discussion_r2208976591
########## pyproject.toml: ########## @@ -131,6 +131,7 @@ solr = ["sqlalchemy-solr >= 0.2.0"] elasticsearch = ["elasticsearch-dbapi>=0.2.9, <0.3.0"] exasol = ["sqlalchemy-exasol >= 2.4.0, <3.0"] excel = ["xlrd>=1.2.0, <1.3"] +fastmcp = ["fastmcp>=2.8.1"] Review Comment: We do have some requirements around logging, testing, and authentication, as described in the [SIP-171](https://github.com/apache/superset/issues/33870). Features like pluggable auth hooks, audit logging, and robust testing are important for our use case. That said, I’m open to approaches—if the python-sdk evolves to support these needs, we could certainly consider it. For now, FastMCP (or a similarly feature-rich server) seems like the best fit, but I’m happy to revisit as things progress. Appreciate your thoughtfulness on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
