betodealmeida commented on code in PR #34177:
URL: https://github.com/apache/superset/pull/34177#discussion_r2208612133
##########
superset/connectors/sqla/models.py:
##########
@@ -1643,43 +1521,6 @@ def _get_series_orderby(
)
return ob
- def _normalize_prequery_result_type(
Review Comment:
The parent method seems more complete, handling cases where `column` is not
a dict. This is one of the major problems with code duplication, things get
fixed in one place but not another. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
